fix: change NVM to nvm #6722
Merged
fix: change NVM to nvm #6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe `nvm` is always lowercase as seen in their readme https://github.com/nvm-sh/nvm/blob/master/README.md Signed-off-by: Steven <steven@ceriously.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
AugustinMauroy
approved these changes
May 14, 2024
Unit Test Coverage Report
Unit Test Report
|
Good point, I just pushed another commit (f415c4d) where the code comment was using the wrong case as well. |
bmuenzenmeyer
approved these changes
May 14, 2024
bmuenzenmeyer
added
fast-track
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe
nvmis always lowercase as seen in their readmehttps://github.com/nvm-sh/nvm/blob/master/README.md
Validation
Visit https://nodejs-org-git-fork-styfle-patch-1-openjs.vercel.app/en/download/package-manager and note the dropdown.
Related Issues
None
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.