Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node 20 to CI checks #518

Merged
merged 1 commit into from May 15, 2023
Merged

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented May 14, 2023

Noticed they were missing when looking into #517

@jeswr
Copy link
Contributor Author

jeswr commented May 14, 2023

I'm noticing that on the CI in my repo one of the tests are timing out on Node 16 on Windows for some reason (see https://github.com/jeswr/readable-stream/actions/runs/4973128200/jobs/8898847989).

I won't dig into it as it seems unrelated to this change, but wanted to note it nonetheless.

@mcollina mcollina merged commit ba27fd8 into nodejs:main May 15, 2023
115 checks passed
@jeswr jeswr deleted the chore/node-20-ci branch May 15, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants