Update to Node.js 18.19.0, add Node 21.x to CI #528
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
@atlowChemi I need some help here in providing a polyfill for |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
@atlowChemi I implemented something, PTAL |
|
All green |
lib/ours/util.js
Outdated
| // validateAbortSignal(signal, 'signal'); | ||
| // validateFunction(listener, 'listener'); |
There was a problem hiding this comment.
Any specific reason to not implement these?
There was a problem hiding this comment.
No particular reasons. Do you know where I can copy them from?
There was a problem hiding this comment.
The biggest reason I didn't test them is that they were not needed for the tests to pass.
There was a problem hiding this comment.
They might not be required for the tests 🤷🏽♂️
https://github.com/nodejs/node/blob/01719333623aaa324d05011ffcba0dddc0ea3666/lib/internal/validators.js#L421-L428
https://github.com/nodejs/node/blob/01719333623aaa324d05011ffcba0dddc0ea3666/lib/internal/validators.js#L438-L441
const validateAbortSignal = (signal, name) => {
if (signal !== undefined &&
(signal === null ||
typeof signal !== 'object' ||
!('aborted' in signal))) {
throw new ERR_INVALID_ARG_TYPE(name, 'AbortSignal', signal);
}
};
const validateFunction = (value, name) => {
if (typeof value !== 'function')
throw new ERR_INVALID_ARG_TYPE(name, 'Function', value);
};
|
cc @atlowChemi |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
No description provided.