Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use globalThis instead of global #530

Merged
merged 2 commits into from Dec 18, 2023
Merged

Use globalThis instead of global #530

merged 2 commits into from Dec 18, 2023

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Dec 18, 2023

Fixes #529

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mofux
Copy link

mofux commented Dec 18, 2023

There's also another occurence in src/util.js:

const AbortSignal = global.AbortSignal || require('abort-controller').AbortSignal
const AbortController = global.AbortController || require('abort-controller').AbortController

However, not sure if this one also needs modification.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina merged commit 75c3201 into main Dec 18, 2023
216 checks passed
@mcollina mcollina deleted the globalthis branch December 18, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.5.0: global is not defined
2 participants