Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lockfile-lint from 4.2.2 to 4.3.3 #89

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps lockfile-lint from 4.2.2 to 4.3.3.

Commits
  • a9bf211 chore(release): publish
  • 7d239ca fix: bump package ver that skipped releases
  • 4e41761 chore(release): publish
  • 828868c fix(readme): update example 3 remove invalid argument (#90)
  • a939b5f chore(release): publish
  • d0002e7 fix(hostvalidator): support full urls for host (#88)
  • 3ff6eb8 feat: add validation success console message (#87)
  • c311c44 test: fix hosts validator tests (#85)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 13, 2020
@Trott
Copy link
Member

Trott commented May 14, 2020

The test failure here looks like a false positive. Looks like it's treating remark-preset-lint-node@1.14.0 in the changelog like it's a bare URL. I guess it's mistaking it for an email address. make lint-md isn't flagging it though. Not sure why. @nschonni

@nschonni
Copy link
Member

The other changelog files disable that rule at the top, but the v14 one doesn't

@dependabot-preview
Copy link
Contributor Author

Superseded by #90.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/lockfile-lint-4.3.3 branch May 14, 2020 08:00
@Trott
Copy link
Member

Trott commented May 14, 2020

The other changelog files disable that rule at the top, but the v14 one doesn't

Still don't understand why make lint-md doesn't result in the same error....

@nschonni
Copy link
Member

Not sure, the only other diff I can see upstream, is that it's still running remark-lint v6 instead of v7, but I don't know if that would really cause an issue

@Trott
Copy link
Member

Trott commented May 15, 2020

Not sure, the only other diff I can see upstream, is that it's still running remark-lint v6 instead of v7, but I don't know if that would really cause an issue

Updating remark-lint didn't replicate it, but updating all the deps did. Thanks!

nodejs/node#33412

Trott added a commit to Trott/io.js that referenced this pull request May 17, 2020
Add a comment to disable a rule in the 14.x changelog that will be
needed once we update remark lint dependencies. This comment appears in
the other changelogs.

Refs: nodejs/remark-preset-lint-node#89 (comment)

PR-URL: nodejs#33412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit to nodejs/node that referenced this pull request May 17, 2020
Add a comment to disable a rule in the 14.x changelog that will be
needed once we update remark lint dependencies. This comment appears in
the other changelogs.

Refs: nodejs/remark-preset-lint-node#89 (comment)

PR-URL: #33412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants