fixup

nodejs · Apr 14, 2023 · 615a68c · 615a68c
1 parent d6491b5
commit 615a68c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -1066,9 +1066,8 @@ async function connect (client) {
     })
   }
 
-  let socket
   try {
-    socket = await new Promise((resolve, reject) => {
+    const socket = await new Promise((resolve, reject) => {
       client[kConnector]({
         host,
         hostname,
@@ -1086,7 +1085,8 @@ async function connect (client) {
     })
 
     if (client.destroyed) {
-      throw new ClientDestroyedError()
+      util.destroy(socket.on('error', () => {}), new ClientDestroyedError())
+      return
     }
 
     if (!llhttpInstance) {
@@ -1131,12 +1131,7 @@ async function connect (client) {
     }
     client.emit('connect', client[kUrl], [client])
   } catch (err) {
-    if (socket) {
-      util.destroy(socket.on('error', () => {}), err)
-    }
-
     if (client.destroyed) {
-      resume(client)
       return
     }
 

diff --git a/types/connector.d.ts b/types/connector.d.ts
@@ -22,7 +22,6 @@ declare namespace buildConnector {
     servername?: string
     localAddress?: string | null
     httpSocket?: Socket,
-    signal?: AbortSignal,
   }
 
   export type Callback = (...args: CallbackArgs) => void