fix: flaky leak test (#2070)

* fix: flaky leak test * fixuP * fixup
nodejs · Apr 14, 2023 · 97154f5 · 97154f5
1 parent 3e91915
commit 97154f5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/test/client-keep-alive.js b/test/client-keep-alive.js
@@ -142,7 +142,7 @@ test('keep-alive header no postfix', (t) => {
       body.on('end', () => {
         const timeout = setTimeout(() => {
           t.fail()
-        }, 3e3)
+        }, 4e3)
         client.on('disconnect', () => {
           t.pass()
           clearTimeout(timeout)

diff --git a/test/connect-timeout.js b/test/connect-timeout.js
@@ -16,8 +16,8 @@ test('priotorise socket errors over timeouts', (t) => {
       t.equal(err.code, 'ENOTFOUND')
     })
 
-  // block for 1001ms which is enough for the dns lookup to complete and TO to fire
-  sleep(connectTimeout + 1)
+  // block for 2s which is enough for the dns lookup to complete and TO to fire
+  sleep(connectTimeout * 2)
 })
 
 // never connect

diff --git a/test/fetch/fetch-leak.js b/test/fetch/fetch-leak.js
@@ -22,6 +22,7 @@ test('do not leak', (t) => {
     const controller = new AbortController()
     fetch(url, { signal: controller.signal })
       .then(res => res.arrayBuffer())
+      .catch(() => {})
       .then(attack)
   })
 
@@ -33,7 +34,7 @@ test('do not leak', (t) => {
     const next = process.memoryUsage().heapUsed
     if (next <= prev) {
       t.pass()
-    } else if (count++ > 10) {
+    } else if (count++ > 20) {
       t.fail()
     } else {
       prev = next