feat: HTTP/2 support #1014
Closed
feat: HTTP/2 support #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
commented
Sep 1, 2021
| } | ||
|
|
||
| try { | ||
| request.onConnect((err) => { |
There was a problem hiding this comment.
Should we call onConnect immediately or on stream ready event? https://nodejs.org/api/http2.html#http2_event_ready
szmarczak
commented
Sep 1, 2021
| session.ref() | ||
| const stream = session.request(headers) | ||
| stream.on('response', headers => { | ||
| if (request.onHeaders(Number(headers[':status']), headers, stream.resume.bind(stream), '') === false) { |
There was a problem hiding this comment.
The handler expects an array but the native http2 module provides us with an object. What should we do?
ronag
reviewed
Sep 1, 2021
| @@ -226,7 +226,7 @@ function processHeader (request, key, val) { | |||
| ) { | |||
| throw new NotSupportedError('expect header not supported') | |||
| } else { | |||
| request.headers += `${key}: ${val}\r\n` | |||
| request.headers[key] = val | |||
ronag
reviewed
Sep 1, 2021
| @@ -29,6 +29,8 @@ function buildConnector ({ maxCachedSessions, socketPath, timeout, ...opts }) { | |||
| const session = sessionCache.get(servername) || null | |||
|
|
|||
| socket = tls.connect({ | |||
| // TODO: @szmarczak: move this to client.js | |||
| ALPNProtocols: ['h2', 'http/1.1'], | |||
There was a problem hiding this comment.
experimental + disabled by default?
|
Maybe would be better to target @jasnell's node http3/quic branch? I'm not too comfortable with node core http2. nodejs/node#38233 |
|
@ronag what's the issue with the core node HTTP/2? |
https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3Ahttp2 |
lifehome
added a commit
to lifehome/whmcs_stockchecker
that referenced
this pull request
Sep 9, 2021
It's still a HTTP/1.1 client cuz nodejs is not HTTP/2 compatible at the time of this commit. See nodejs/undici#1014 for more details.
lifehome
added a commit
to lifehome/whmcs_stockchecker
that referenced
this pull request
Sep 11, 2021
It's still a HTTP/1.1 client cuz nodejs is not HTTP/2 compatible at the time of this commit. See nodejs/undici#1014 for more details.
ronag
force-pushed
the
main
branch
2 times, most recently
from
a2ad318
to
904e045
Compare
ronag
force-pushed
the
main
branch
3 times, most recently
from
dcb1656
to
af20fdc
Compare
ronag
force-pushed
the
main
branch
2 times, most recently
from
63eab1d
to
47eb207
Compare
2 tasks
|
Superseded by #2061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP