Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept third-party Blobs in FormData #1099

Merged
merged 3 commits into from
Nov 17, 2021
Merged

feat: accept third-party Blobs in FormData #1099

merged 3 commits into from
Nov 17, 2021

Conversation

wojpawlik
Copy link
Contributor

Works around nodejs/node#37340.
Advances telegraf/telegraf#1502.
Closes #930.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #1099 (bac3ee2) into main (64d07c3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          39       39           
  Lines        3780     3780           
=======================================
  Hits         3583     3583           
  Misses        197      197           
Impacted Files Coverage Δ
lib/fetch/formdata.js 100.00% <100.00%> (ø)
lib/fetch/util.js 75.00% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d07c3...bac3ee2. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Can you please add a unit test?

lib/fetch/util.js Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 46eff3f into nodejs:main Nov 17, 2021
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormData
4 participants