fix: errored stream is disturbed #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
Dec 8, 2021
|
@szmarczak This is a spec thing. Care to help clarifying what is the correct behaviour. |
Codecov Report
@@ Coverage Diff @@
## main #1134 +/- ##
==========================================
- Coverage 94.30% 94.30% -0.01%
==========================================
Files 40 40
Lines 3809 3808 -1
==========================================
- Hits 3592 3591 -1
Misses 217 217
Continue to review full report at Codecov.
|
|
Chrome seems to go with TypeError. |
|
@jimmywarting: Any thoughts? I believe node-fetch fails with an |
|
Umm. is there any wpt test or something in the spec that mention what should actually be happening? |
mcollina
reviewed
Dec 8, 2021
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Dec 9, 2021
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Dec 9, 2021
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Dec 9, 2021
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Dec 9, 2021
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Dec 9, 2021
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Dec 9, 2021
|
Sorry for my inactivity, had a few tests and an exam in uni. Will take a look now. |
szmarczak
reviewed
Dec 9, 2021
|
@jimmywarting whatwg/streams#1025 tl;dr unfortunately it's up to Node.js, because they made a design mistake to allow fetch access stream internals. |
mcollina
reviewed
Dec 9, 2021
There is already unit test? I updated the relevant one. |
|
I missed it. CI is failing. |
szmarczak
approved these changes
Dec 10, 2021
ronag
added a commit
to nodejs/node
that referenced
this pull request
Dec 16, 2021
Refs: nodejs/undici#1134 PR-URL: #41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 16, 2021
Refs: nodejs/undici#1134 PR-URL: #41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 17, 2021
Refs: nodejs/undici#1134 PR-URL: #41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs/undici#1134 PR-URL: #41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs/undici#1134 PR-URL: nodejs#41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 1, 2022
Refs: nodejs/undici#1134 PR-URL: #41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix: errored stream is disturbed * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: errored stream is disturbed * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: errored stream is disturbed * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.