Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make fetch's signature spec-compliant #1226

Merged
merged 1 commit into from Feb 12, 2022
Merged

fix: make fetch's signature spec-compliant #1226

merged 1 commit into from Feb 12, 2022

Conversation

targos
Copy link
Member

@targos targos commented Feb 12, 2022

No description provided.

mcollina
mcollina approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

There are conflicts to resolve.

@targos
Copy link
Member Author

targos commented Feb 12, 2022

Conflicts resolved.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022 •
edited

Codecov Report

Merging #1226 (1306535) into main (db745e4) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
+ Coverage   93.43%   93.85%   +0.41%     
==========================================
  Files          43       43              
  Lines        4052     4052              
==========================================
+ Hits         3786     3803      +17     
+ Misses        266      249      -17
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)
lib/fetch/index.js 77.66% <0.00%> (+0.19%) ⬆️
lib/fetch/file.js 85.41% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db745e4...1306535. Read the comment docs.

@ronag ronag merged commit 3e267ec into nodejs:main Feb 12, 2022
@targos targos deleted the fetch-name-length branch February 12, 2022 11:36
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
@targos @KhafraDev
fix: make fetch's signature spec-compliant (nodejs#1226)
9af189a
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@targos @metcoder95
fix: make fetch's signature spec-compliant (nodejs#1226)
97b974c
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@targos @crysmags
fix: make fetch's signature spec-compliant (nodejs#1226)
a885ff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@targos @mcollina @codecov-commenter @ronag