Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RequestInit doesn't allow explicit undefined #1242

Merged
merged 1 commit into from Feb 19, 2022
Merged

fix: RequestInit doesn't allow explicit undefined #1242

merged 1 commit into from Feb 19, 2022

Conversation

chlonel
Copy link
Contributor

@chlonel chlonel commented Feb 19, 2022

Fixes: #1225

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022 •
edited

Codecov Report

Merging #1242 (14f0bc5) into main (b081930) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   93.87%   94.05%   +0.17%     
==========================================
  Files          43       43              
  Lines        4052     4052              
==========================================
+ Hits         3804     3811       +7     
+ Misses        248      241       -7
Impacted Files Coverage Δ
lib/fetch/request.js 85.47% <100.00%> (+2.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b081930...14f0bc5. Read the comment docs.

mcollina
mcollina approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit df3f54c into nodejs:main Feb 19, 2022
@Cyb3r-Jak3 Cyb3r-Jak3 mentioned this pull request Mar 17, 2022
Closed
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
@chlonel @KhafraDev
fix: RequestInit doesn't allow explicit undefined (nodejs#1242)
3ab1a69
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@chlonel @metcoder95
fix: RequestInit doesn't allow explicit undefined (nodejs#1242)
cd5e072
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@chlonel @crysmags
fix: RequestInit doesn't allow explicit undefined (nodejs#1242)
a5588e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@ronag ronag ronag left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch options do not allow explicit undefined
5 participants
@chlonel @codecov-commenter @mcollina @targos @ronag