New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow string[] as Record value on HeadersInit #1244
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1244 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 43 43
Lines 4071 4071
=======================================
Hits 3830 3830
Misses 241 241 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type change is fine but the test should exist somewhere else I think
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
* fix(fetch): allow string[] as Record value on HeadersInit * fix(fetch): allow readonly string arrays on HeadersInit * refact(fetch): move HeadersInit test to test/fetch
This is a TypeScript-only change, undici already handles Records with string[] values: https://runkit.com/embed/972d5c6lsor2
A test was created to ensure this feature works properly