Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: normalize origin for BalancedPool addUpstream/removeUpstream #1252

Merged
merged 1 commit into from Feb 27, 2022

Conversation

mnutt
Copy link
Contributor

@mnutt mnutt commented Feb 25, 2022

Fixes #1250.

Calls parseOrigin on upstream addition/removal to ensure that finding an existing upstream by origin works when deduplicating/removing an upstream.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1252 (fb26a5b) into main (662fd82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          43       43           
  Lines        4071     4074    +3     
=======================================
+ Hits         3830     3833    +3     
  Misses        241      241           
Impacted Files Coverage Δ
lib/balanced-pool.js 97.61% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662fd82...fb26a5b. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 1e04cf3 into nodejs:main Feb 27, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize BalancedPool addUpstream / removeUpstream
4 participants