New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve BodyReadable type definition #1259
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1259 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 44 44
Lines 4089 4089
=======================================
Hits 3848 3848
Misses 241 241 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we tests our types using tsd. Could you add a test?
@mcollina does it make sense to add types from the |
I can try pushing up what I have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* fix: Improve BodyReadable type definition * fix: Add tests for BodyReadable type
* fix: Improve BodyReadable type definition * fix: Add tests for BodyReadable type
* fix: Improve BodyReadable type definition * fix: Add tests for BodyReadable type
Updates the
body
to useBodyReadable
. Currently, body was using an intersection betweenReadable
andBodyMixin
.This actually exposes the
dump
function in TypeScript now.Let me know if the
resume
andabort
are actually nullable. I looked at the code andabort
isnull
initially.resume
seems to be optional forReadable
Fixes #1256