Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove esbuild from dev dependencies #1268

Merged

Conversation

targos
Copy link
Member

@targos targos commented Mar 7, 2022

It breaks AIX in CITGM. Use npx instead.

It breaks AIX in CITGM. Use npx instead.
@targos targos linked an issue Mar 7, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #1268 (16cae35) into main (37d6fce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1268   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files          44       44           
  Lines        4090     4090           
=======================================
  Hits         3849     3849           
  Misses        241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d6fce...16cae35. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 946ea78 into main Mar 7, 2022
@targos targos deleted the 1267-drop-esbuild-as-a-devdep-as-its-not-supported-on-aix branch March 7, 2022 07:49
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
It breaks AIX in CITGM. Use npx instead.
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
It breaks AIX in CITGM. Use npx instead.
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
It breaks AIX in CITGM. Use npx instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop esbuild as a devDep as it's not supported on AIX
4 participants