New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mock): allow matching the complete header list #1275
Conversation
Might need to use a regular object instead of Headers for node < 16 compat. Happy to do so given otherwise non blocking feedback. |
code looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## main #1275 +/- ##
==========================================
+ Coverage 94.10% 94.11% +0.01%
==========================================
Files 44 44
Lines 4090 4097 +7
==========================================
+ Hits 3849 3856 +7
Misses 241 241
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
resolves #1269 and (subjectively) a preferred alternative to #1274