New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lazy decode body #1276
fix: lazy decode body #1276
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 94.11% 96.48% +2.37%
==========================================
Files 44 33 -11
Lines 4093 2562 -1531
==========================================
- Hits 3852 2472 -1380
+ Misses 241 90 -151
Continue to review full report at Codecov.
|
Don't start decoding the body before headers and status has been processed. Fixes: #1271
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a unit test?
@minas90 Would you mind helping with a test? |
Maybe @KhafraDev can help with test? |
I couldn't replicate the issue |
* fix: lazy decode body Don't start decoding the body before headers and status has been processed. Fixes: nodejs#1271 * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
* fix: lazy decode body Don't start decoding the body before headers and status has been processed. Fixes: nodejs#1271 * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
* fix: lazy decode body Don't start decoding the body before headers and status has been processed. Fixes: nodejs#1271 * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup * fixup
Don't start prefetching the body before headers and status
has been processed.
Fixes: #1271