refactor: unify close/destroy #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 94.13% 94.05% -0.08%
==========================================
Files 44 45 +1
Lines 4091 4055 -36
==========================================
- Hits 3851 3814 -37
- Misses 240 241 +1
Continue to review full report at Codecov.
|
ronag
commented
Mar 18, 2022
| } | ||
|
|
||
| if (this[kDestroyed]) { | ||
| queueMicrotask(() => callback(new ClientDestroyedError(), null)) |
There was a problem hiding this comment.
I don't think this was an error before in all cases (hence the updates to test). It behaved inconsistently. Not sure what is most correct.
ronag
force-pushed
the
unifty-teardown
branch
2 times, most recently
from
25c3a07
to
33b4fe3
Compare
ronag
added
the
semver-major
|
@mcollina semver-major or not? wdyt? It will now error some close calls that did not error before. |
mcollina
reviewed
Mar 22, 2022
|
Benchmarks have only one sample so I don't think they are very accurate but it looks good to me. |
|
I'm good with semver major |
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* refactor: unify close/destroy * fixup * fixup * fixup
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* refactor: unify close/destroy * fixup * fixup * fixup
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* refactor: unify close/destroy * fixup * fixup * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.