Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove istanbule ignore and add test for bad upgrade #1279

Merged
merged 1 commit into from Mar 15, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Mar 15, 2022

This PR partially fixes #706.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #1279 (d62e9ac) into main (2d7059b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1279   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          44       44           
  Lines        4096     4098    +2     
=======================================
+ Hits         3855     3857    +2     
  Misses        241      241           
Impacted Files Coverage Δ
lib/client.js 98.04% <ø> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7059b...d62e9ac. Read the comment docs.

@mcollina
Copy link
Member

Thanks!!

@mcollina mcollina merged commit 2336d25 into nodejs:main Mar 15, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to remove istanbul ignore
3 participants