Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix duplicated error import in test/agent.js #1288

Merged
merged 1 commit into from Mar 17, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Mar 17, 2022

This PR refactors test/agent.js.

  • It imports ../ and ../index but those are the same.
  • It uses InvalidArgumentError and errors.InvalidArgumentError but those are the same.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #1288 (f4c12ed) into main (d7eac3e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
+ Coverage   94.11%   94.14%   +0.02%     
==========================================
  Files          44       44              
  Lines        4098     4098              
==========================================
+ Hits         3857     3858       +1     
+ Misses        241      240       -1     
Impacted Files Coverage Δ
lib/fetch/index.js 77.86% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7eac3e...f4c12ed. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f1739cf into nodejs:main Mar 17, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants