fix: Do not use WeakRef on mocks. #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
approved these changes
Mar 18, 2022
Codecov Report
@@ Coverage Diff @@
## main #1290 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 44 44
Lines 4098 4099 +1
=======================================
+ Hits 3858 3859 +1
Misses 240 240
Continue to review full report at Codecov.
|
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix: Do not use WeakRef on mocks. * fix: Linting errors. * fix: Fixed test on older versions of Node.
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: Do not use WeakRef on mocks. * fix: Linting errors. * fix: Fixed test on older versions of Node.
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: Do not use WeakRef on mocks. * fix: Linting errors. * fix: Fixed test on older versions of Node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a very hard to spot bug that happens under these conditions:
mockAgent.get) is setup within a function and no reference to the pool/client is returned.What happens is that the original pool/client is garbage collected and thus all the set interceptors are gone, leading to either test failure or unwanted network activity.
The PR fixes that by using a
FakeWeakRefin theMockAgentthat keeps a reference to the pool and thus no garbage collection happens.