Fix broken bench scripts #1291
Merged
Fix broken bench scripts #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1291 +/- ##
==========================================
+ Coverage 94.14% 94.18% +0.03%
==========================================
Files 44 44
Lines 4098 4126 +28
==========================================
+ Hits 3858 3886 +28
Misses 240 240
Continue to review full report at Codecov.
|
|
@ShogunPanda @RafaelGSS could you take a look? |
RafaelGSS
reviewed
Mar 18, 2022
| @@ -129,6 +129,8 @@ function printResults (results) { | |||
| ] | |||
| }) | |||
|
|
|||
| console.log(results) | |||
There was a problem hiding this comment.
Suggested change
| console.log(results) |
There was a problem hiding this comment.
This is needed for debugging this and showing that it's using one sample anyway
| @@ -10,7 +10,7 @@ const { WritableStream } = require('stream/web') | |||
|
|
|||
| const { Pool, Client, fetch, Agent, setGlobalDispatcher } = require('..') | |||
|
|
|||
| const iterations = (parseInt(process.env.SAMPLES, 10) || 100) + 1 | |||
| const iterations = (parseInt(process.env.SAMPLES, 10) || 10) + 1 | |||
There was a problem hiding this comment.
Why does it need to change? I have run it locally and it's working fine. When 10 it uses only 1 sample.
There was a problem hiding this comment.
Nothing, I committed my current branch.
Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
ronag
approved these changes
Mar 19, 2022
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* partial fix for bench * fix lint * Update benchmarks/benchmark.js Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com> Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* partial fix for bench * fix lint * Update benchmarks/benchmark.js Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com> Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* partial fix for bench * fix lint * Update benchmarks/benchmark.js Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com> Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bench CI job is not working anymore. This PR partially fixes it but the number of iterations do not work anymore.