Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint error #1293

Merged
merged 2 commits into from Mar 19, 2022
Merged

Fix lint error #1293

merged 2 commits into from Mar 19, 2022

Conversation

is2ei
Copy link
Contributor

@is2ei is2ei commented Mar 19, 2022

Changes

  • This PR suppresses lint error on WIP implementation.
  • This PR adds the lint command to the pre-commit hook.

References

https://github.com/nodejs/undici/runs/5610494557?check_suite_focus=true

> undici@4.1[6](https://github.com/nodejs/undici/runs/5610494557?check_suite_focus=true#step:5:6).0 lint
> standard | snazzy

standard: Use JavaScript Standard Style (https://standardjs.com)

/home/runner/work/undici/undici/lib/fetch/index.js
  15[8](https://github.com/nodejs/undici/runs/5610494557?check_suite_focus=true#step:5:8)[9](https://github.com/nodejs/undici/runs/5610494557?check_suite_focus=true#step:5:9):[11](https://github.com/nodejs/undici/runs/5610494557?check_suite_focus=true#step:5:11)  error  'newConnection' is assigned a value but never used

✖ 1 problem
Error: Process completed with exit code 1.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #1293 (129d71e) into main (a15bef3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
- Coverage   94.14%   94.12%   -0.03%     
==========================================
  Files          44       44              
  Lines        4100     4100              
==========================================
- Hits         3860     3859       -1     
- Misses        240      241       +1     
Impacted Files Coverage Δ
lib/fetch/index.js 77.90% <100.00%> (ø)
lib/fetch/request.js 85.06% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15bef3...129d71e. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f620981 into nodejs:main Mar 19, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants