Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fetch): refactor httpNetworkOrCacheFetch #1294

Merged
merged 16 commits into from Mar 20, 2022
Merged

refactor(fetch): refactor httpNetworkOrCacheFetch #1294

merged 16 commits into from Mar 20, 2022

Conversation

ronag
Copy link
Member

@ronag ronag commented Mar 20, 2022

Restructure the implementation so that it more clearly
follows the spec.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #1294 (f4d8af5) into main (65763ca) will decrease coverage by 0.10%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   94.13%   94.03%   -0.11%     
==========================================
  Files          44       44              
  Lines        4091     4106      +15     
==========================================
+ Hits         3851     3861      +10     
- Misses        240      245       +5     
Impacted Files Coverage Δ
lib/fetch/response.js 92.42% <ø> (ø)
lib/fetch/index.js 77.20% <91.66%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65763ca...f4d8af5. Read the comment docs.

@ronag

This comment was marked as resolved.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 62c1162 into main Mar 20, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* refactor(fetch): refactor httpNetworkOrCacheFetch

Restructure the implementation so that it more clearly
follows the spec.

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixuP

* fixuP

* fixuP

* fixup

* fixup

* fixup

* fixuP
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* refactor(fetch): refactor httpNetworkOrCacheFetch

Restructure the implementation so that it more clearly
follows the spec.

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixuP

* fixuP

* fixuP

* fixup

* fixup

* fixup

* fixuP
@Uzlopak Uzlopak deleted the fetch2 branch February 21, 2024 12:37
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* refactor(fetch): refactor httpNetworkOrCacheFetch

Restructure the implementation so that it more clearly
follows the spec.

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixup

* fixuP

* fixuP

* fixuP

* fixup

* fixup

* fixup

* fixuP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants