Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export Interceptable interface #1311

Merged
merged 1 commit into from Mar 30, 2022

Conversation

fraxken
Copy link
Member

@fraxken fraxken commented Mar 29, 2022

PR related to #1306

Not sure if i had to add a new TSD test somewhere for this new export.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this? We use tsd.

fix: add missing TSD test
@fraxken
Copy link
Member Author

fraxken commented Mar 30, 2022

Done, not sure if i also need to add an expectAssignable in mock-interceptor.test-d.ts ? Since it was about a new exported type i focused on index.test-d.ts.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit dc63a4d into nodejs:main Mar 30, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants