Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CORB check. #1312

Merged
merged 3 commits into from Mar 30, 2022
Merged

feat: CORB check. #1312

merged 3 commits into from Mar 30, 2022

Conversation

hemanth
Copy link
Contributor

@hemanth hemanth commented Mar 29, 2022

Implemented CORBcheck as per the spec

Maybe isCORBProtectedMIME needs to be polished?

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2022

Codecov Report

Merging #1312 (e903faa) into main (08839e4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   94.16%   94.18%   +0.01%     
==========================================
  Files          45       45              
  Lines        4113     4126      +13     
==========================================
+ Hits         3873     3886      +13     
  Misses        240      240              
Impacted Files Coverage Δ
lib/fetch/util.js 80.21% <100.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08839e4...e903faa. Read the comment docs.

test/fetch/util.js Outdated Show resolved Hide resolved
lib/fetch/util.js Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 83defac into nodejs:main Mar 30, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* feat: CORB check.

* Update lib/fetch/util.js

* Update test/fetch/util.js

Co-authored-by: Robert Nagy <ronagy@icloud.com>
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* feat: CORB check.

* Update lib/fetch/util.js

* Update test/fetch/util.js

Co-authored-by: Robert Nagy <ronagy@icloud.com>
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* feat: CORB check.

* Update lib/fetch/util.js

* Update test/fetch/util.js

Co-authored-by: Robert Nagy <ronagy@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants