fix(fetch): add missing ReadableStream interface to response.body #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
reviewed
Mar 30, 2022
…dejs#1308) refactor: remove ControlledAsyncIterable
fraxken
force-pushed
the
readable-response-body
branch
from
394570f
to
ae9b890
Compare
ronag
approved these changes
Mar 30, 2022
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
|
This change broke undici's support for working with @types/node < 16.x.x, because the ReadableStream type does not exist under stream/web in those versions. Not sure if this project considers this a problem, since it technically still runs on Node 12 and 14, but cannot be compiled without using a different set of types. |
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing ReadableStream type to fetch response.body (relate to #1308).
Hope i have not missed something,
maybe we need a seperate type for(ControlledAsyncIterable & ReadableStream) | null?