New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove logical assignment operator #1318
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1318 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 45 45
Lines 4125 4125
=======================================
Hits 3885 3885
Misses 240 240
Continue to review full report at Codecov.
|
Thanks! |
@ronag any planned release soon with this fix? |
Are you sure this is the only issue? Right now, the |
Fetch does not work on node 14. This is expected. |
* fix: remove logical assignment operator * chore: please the linter
* fix: remove logical assignment operator * chore: please the linter
* fix: remove logical assignment operator * chore: please the linter
Hey, a user of one of our libraries reported an unexpected syntax error on Node.js 14, which I tracked down to this line.
The package.json of this project lists
"node": ">=12.18"
in the engines.Logical Assignment is only supported since Node.js 15.14.
To me, it seems like this usage here got added unexpectedly.
We would love to prevent such things in the future by setting up a GitHub action that runs eslint with the following rule: https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/es-syntax.md
Would that be something you are interested in?