Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mock bugs #1323

Merged
merged 5 commits into from Apr 6, 2022
Merged

Fix mock bugs #1323

merged 5 commits into from Apr 6, 2022

Conversation

KhafraDev
Copy link
Member

Fixes #1321
Fixes #1320

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #1323 (9767dbc) into main (46953d5) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   94.15%   94.27%   +0.11%     
==========================================
  Files          45       45              
  Lines        4106     4192      +86     
==========================================
+ Hits         3866     3952      +86     
  Misses        240      240              
Impacted Files Coverage Δ
lib/mock/mock-interceptor.js 100.00% <100.00%> (ø)
lib/mock/mock-utils.js 100.00% <100.00%> (ø)
lib/fetch/index.js 80.29% <0.00%> (+0.03%) ⬆️
lib/fetch/util.js 80.00% <0.00%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46953d5...9767dbc. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 37e6dad into nodejs:main Apr 6, 2022
@KhafraDev KhafraDev deleted the fix-mock-bugs branch April 6, 2022 14:53
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* fix(MockAgent): allow lowercase `method`

* fix(MockAgent): set statusText properly

* add test for bad statusCode

* skip test on v14 and lower

* code cov
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* fix(MockAgent): allow lowercase `method`

* fix(MockAgent): set statusText properly

* add test for bad statusCode

* skip test on v14 and lower

* code cov
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix(MockAgent): allow lowercase `method`

* fix(MockAgent): set statusText properly

* add test for bad statusCode

* skip test on v14 and lower

* code cov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants