Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow FormData bodies in request #1332

Merged
merged 4 commits into from Apr 13, 2022
Merged

feat: allow FormData bodies in request #1332

merged 4 commits into from Apr 13, 2022

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Apr 12, 2022

Fixes #1330

Allows sending a FormData body to undici.request.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #1332 (d0c91a4) into main (c0961f4) will decrease coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
- Coverage   94.10%   94.09%   -0.01%     
==========================================
  Files          45       45              
  Lines        4189     4201      +12     
==========================================
+ Hits         3942     3953      +11     
- Misses        247      248       +1     
Impacted Files Coverage Δ
lib/client.js 97.83% <91.66%> (-0.10%) ⬇️
lib/core/util.js 98.48% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0961f4...d0c91a4. Read the comment docs.

lib/client.js Outdated Show resolved Hide resolved
@mcollina
Copy link
Member

go ahead and add busboy!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit 2ea8f03 into nodejs:main Apr 13, 2022
@KhafraDev KhafraDev deleted the request-formdata branch April 13, 2022 04:37
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* feat: allow `FormData` bodies in `request`

* add test for FormData body on node <16

* fix: bad version check

* test: add busboy formdata parsing
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* feat: allow `FormData` bodies in `request`

* add test for FormData body on node <16

* fix: bad version check

* test: add busboy formdata parsing
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* feat: allow `FormData` bodies in `request`

* add test for FormData body on node <16

* fix: bad version check

* test: add busboy formdata parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: allow sending FormData in undici.request?
5 participants