Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formdata cleanup #1336

Merged
merged 2 commits into from Apr 13, 2022
Merged

fix: formdata cleanup #1336

merged 2 commits into from Apr 13, 2022

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 13, 2022

No description provided.

@ronag ronag requested a review from mcollina April 13, 2022 14:49
@ronag
Copy link
Member Author

ronag commented Apr 13, 2022

@KhafraDev

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #1336 (febf071) into main (2ea8f03) will increase coverage by 0.00%.
The diff coverage is 93.75%.

❗ Current head febf071 differs from pull request most recent head ed8cebb. Consider uploading reports for the commit ed8cebb to get more accurate results

@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          45       45           
  Lines        4201     4202    +1     
=======================================
+ Hits         3953     3954    +1     
  Misses        248      248           
Impacted Files Coverage Δ
lib/core/request.js 97.97% <92.85%> (-0.56%) ⬇️
lib/client.js 97.93% <100.00%> (+0.09%) ⬆️
lib/fetch/body.js 98.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea8f03...ed8cebb. Read the comment docs.

lib/core/request.js Outdated Show resolved Hide resolved
lib/core/request.js Outdated Show resolved Hide resolved
@KhafraDev
Copy link
Member

Much nicer now!

@@ -11,6 +11,13 @@ const kHandler = Symbol('handler')

const channels = {}

let extractBody

const [nodeMajor, nodeMinor] = process.version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe #1335 can be implemented here as well?

@ronag ronag merged commit 4b52053 into main Apr 13, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* fix: formdata cleanup

* Update lib/core/request.js
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* fix: formdata cleanup

* Update lib/core/request.js
@Uzlopak Uzlopak deleted the form-data branch February 21, 2024 12:37
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix: formdata cleanup

* Update lib/core/request.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants