Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Headers): filter out forbidden headers & get should return null on unknown header name #1337

Merged
merged 2 commits into from Apr 13, 2022
Merged

Conversation

KhafraDev
Copy link
Member

Fixes #1328

Two issues with the recently added filtered lists and using Proxy.

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #1337 (f87b7f7) into main (2ea8f03) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          45       45           
  Lines        4201     4202    +1     
=======================================
+ Hits         3953     3954    +1     
  Misses        248      248           
Impacted Files Coverage Δ
lib/fetch/response.js 86.66% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea8f03...f87b7f7. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 63d435a into nodejs:main Apr 13, 2022
@KhafraDev KhafraDev deleted the set-cookie branch April 13, 2022 17:26
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
… on unknown header name (nodejs#1337)

* fix: headers

* re-run ci
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
… on unknown header name (nodejs#1337)

* fix: headers

* re-run ci
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
… on unknown header name (nodejs#1337)

* fix: headers

* re-run ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange result with set-cookie header of undici.fetch
4 participants