doc: fix documented mock request example #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinkelleher
commented
Apr 16, 2022
austinkelleher
commented
Apr 16, 2022
| import { request } from 'undici' | ||
|
|
||
| export async function bankTransfer(recepient, ammount) { | ||
| const { body } = await request('http://localhost:3000/bank-transfer', | ||
| const { body } = await request('http://localhost:3000/bank-transfer', |
There was a problem hiding this comment.
According to the undici .editorconfig, trimming trailing whitespace is the preferred style.
Codecov Report
@@ Coverage Diff @@
## main #1341 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 45 45
Lines 4205 4205
=======================================
Hits 3958 3958
Misses 247 247 Continue to review full report at Codecov.
|
austinkelleher
force-pushed
the
doc-mocking-request-fix
branch
from
7dc1758
to
4a44a6b
Compare
austinkelleher
commented
Apr 16, 2022
| import { request } from 'undici' | ||
|
|
||
| export async function bankTransfer(recepient, ammount) { | ||
| const { body } = await request('http://localhost:3000/bank-transfer', | ||
| export async function bankTransfer(recepient, amount) { |
There was a problem hiding this comment.
Typo correction ammount -> amount
| body: JSON.stringify({ recepient }) | ||
| body: JSON.stringify({ | ||
| recepient, | ||
| amount |
There was a problem hiding this comment.
This was the real fix. amount wasn't being included in the body and caused the first assertion to fail.
| @@ -28,7 +31,7 @@ And this is what the test file looks like: | |||
| // index.test.mjs | |||
| import { strict as assert } from 'assert' | |||
| import { MockAgent, setGlobalDispatcher, } from 'undici' | |||
| import { bankTransfer } from './undici.mjs' | |||
| import { bankTransfer } from './bank.mjs' | |||
There was a problem hiding this comment.
mcollina
approved these changes
Apr 16, 2022
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to a mock request example that was broken.