docs(readme): minor grammar fixes #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 45 45
Lines 4204 4204
=======================================
Hits 3962 3962
Misses 242 242 Continue to review full report at Codecov.
|
ronag
reviewed
Apr 22, 2022
ronag
reviewed
Apr 22, 2022
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
reviewed
Apr 22, 2022
ronag
reviewed
Apr 22, 2022
README.md
Outdated
| This section documents parts of the [Fetch Standard](https://fetch.spec.whatwg.org) which Undici does | ||
| not support or does not fully implement. | ||
| This section documents parts of the [Fetch Standard](https://fetch.spec.whatwg.org) that Undici does | ||
| not support or fully implement. |
There was a problem hiding this comment.
From rereading it the removal of the additional "does not" reduces clarity for the sake of conciseness, I agree.
ronag
reviewed
Apr 22, 2022
README.md
Outdated
| This section documents parts of the HTTP/1.1 specification which Undici does | ||
| not support or does not fully implement. | ||
| This section documents parts of the HTTP/1.1 specification that Undici does | ||
| not support or fully implement. |
ronag
reviewed
Apr 22, 2022
README.md
Outdated
| @@ -348,7 +348,7 @@ aborted. | |||
|
|
|||
| ### Manual Redirect | |||
|
|
|||
| Since it is not possible to manually follow an HTTP redirect on server-side, | |||
| Since it is not possible to manually follow an HTTP redirect server-side, | |||
There was a problem hiding this comment.
Could be "on the server-side"?
There was a problem hiding this comment.
Updated in 4d9f60d
|
Thanks! |
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* docs(readme): minor grammar fixes * Update README.md Co-authored-by: Robert Nagy <ronagy@icloud.com> * docs(readme): clarity updates Co-authored-by: Robert Nagy <ronagy@icloud.com>
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* docs(readme): minor grammar fixes * Update README.md Co-authored-by: Robert Nagy <ronagy@icloud.com> * docs(readme): clarity updates Co-authored-by: Robert Nagy <ronagy@icloud.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* docs(readme): minor grammar fixes * Update README.md Co-authored-by: Robert Nagy <ronagy@icloud.com> * docs(readme): clarity updates Co-authored-by: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PR title states: teeny tiny grammatical fixes.