build: add support for lint-pr GitHub action workflow 🕺
#1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vinayakkulkarni
commented
Apr 21, 2022
vinayakkulkarni
commented
- Enables checking on the title of Pull Requests, whether they follow the conventional commits or not
- Example of usage – https://github.com/geospoc/v-mapbox/actions/workflows/lint-pr.yml
ronag
approved these changes
Apr 22, 2022
Fdawgs
reviewed
Apr 22, 2022
| name: 'Lint PR' | ||
|
|
||
| on: | ||
| pull_request_target: |
There was a problem hiding this comment.
Using pull_request_target is risky and has a lot of security implications, see the following:
Permissions would need to be added to the workflow to restrict what it can do, i.e.:
permissions:
pull-requests: write
There was a problem hiding this comment.
I missed this, sorry! Could you swnd a PR?
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.