fix: ProxyAgent dispatch options receives a header array when using fetch #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelGSS
reviewed
Apr 22, 2022
Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
==========================================
+ Coverage 94.12% 94.25% +0.12%
==========================================
Files 45 45
Lines 4204 4211 +7
==========================================
+ Hits 3957 3969 +12
+ Misses 247 242 -5
Continue to review full report at Codecov.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Lint failure |
KhafraDev
added a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
…etch (nodejs#1363) * fix: don't spread array * Update lib/proxy-agent.js Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com> * test: improve test Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
…etch (nodejs#1363) * fix: don't spread array * Update lib/proxy-agent.js Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com> * test: improve test Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
…etch (nodejs#1363) * fix: don't spread array * Update lib/proxy-agent.js Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com> * test: improve test Co-authored-by: Rafael Silva <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1355
types were already correct (I'm guessing this issue has been around for a little bit):
undici/types/dispatcher.d.ts
Line 49 in 1dc2977