Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mock-utils): match header when using fetch #1393

Merged
merged 2 commits into from May 2, 2022
Merged

fix(mock-utils): match header when using fetch #1393

merged 2 commits into from May 2, 2022

Conversation

KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented May 1, 2022 •
edited

Fixes: #1392

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022 •
edited

Codecov Report

Merging #1393 (6bab607) into main (088518a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1393      +/-   ##
==========================================
+ Coverage   94.29%   94.30%   +0.01%     
==========================================
  Files          47       47              
  Lines        4240     4248       +8     
==========================================
+ Hits         3998     4006       +8     
  Misses        242      242
Impacted Files Coverage Δ
lib/mock/mock-utils.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088518a...6bab607. Read the comment docs.

RafaelGSS
RafaelGSS approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These ones are hard to find in the implementation of the new header without a test, good catch.

@ronag ronag merged commit c9f3109 into nodejs:main May 2, 2022
@KhafraDev KhafraDev deleted the fix-mock-intercepting-headers branch May 2, 2022 14:15
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
@KhafraDev
fix(mock-utils): match header when using fetch (nodejs#1393)
34a0458
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@KhafraDev @metcoder95
fix(mock-utils): match header when using fetch (nodejs#1393)
299a30f
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@KhafraDev @crysmags
fix(mock-utils): match header when using fetch (nodejs#1393)
cbcc36c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fetch] 5.1.0 regressed ability to intercept headers
4 participants
@KhafraDev @codecov-commenter @ronag @RafaelGSS