Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit loop early if request was aborted #1396

Merged
merged 1 commit into from May 2, 2022

Conversation

KhafraDev
Copy link
Member

Fixes #1389

Sorry about that, I got lazy and didn't realize recreating the fork would close PRs 馃樀

Applies ronag's suggestion from #1390

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from ronag May 2, 2022 14:49
@ronag ronag merged commit 48bb082 into nodejs:main May 2, 2022
@KhafraDev KhafraDev deleted the fix-same-abortcontroller-abort branch May 2, 2022 16:44
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with parallel fetch() and the same abort signal
3 participants