fix(Request): allow passing Headers instance to init.headers #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
reviewed
May 2, 2022
ronag
reviewed
May 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 49 49
Lines 4248 4248
=======================================
Hits 4005 4005
Misses 243 243
Continue to review full report at Codecov.
|
ronag
requested changes
May 3, 2022
lmachens
added a commit
to playt-net/rolling-rick
that referenced
this pull request
May 9, 2022
Due to an issue in Node.js 18.1.0 with fetch implementation of undici, the request content-type was invalid. See nodejs/undici#1401 This change makes sure to always use stable node-fetch.
KhafraDev
added a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
…1401) * fix(Request): allow passing Headers instance to init.headers * fix(Request): remove unnecessary condition * test: fix node-fetch test failures * fixup Co-authored-by: Robert Nagy <ronagy@icloud.com>
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
…1401) * fix(Request): allow passing Headers instance to init.headers * fix(Request): remove unnecessary condition * test: fix node-fetch test failures * fixup Co-authored-by: Robert Nagy <ronagy@icloud.com>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
…1401) * fix(Request): allow passing Headers instance to init.headers * fix(Request): remove unnecessary condition * test: fix node-fetch test failures * fixup Co-authored-by: Robert Nagy <ronagy@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1400