Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restored compatibility with cronometro. #1406

Merged
merged 1 commit into from May 3, 2022
Merged

fix: Restored compatibility with cronometro. #1406

merged 1 commit into from May 3, 2022

Conversation

ShogunPanda
Copy link
Contributor

This fixed compatibility with ESM version of cronometro.

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #1406 (315dbd9) into main (569bddd) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
- Coverage   94.30%   94.28%   -0.03%     
==========================================
  Files          47       47              
  Lines        4248     4250       +2     
==========================================
+ Hits         4006     4007       +1     
- Misses        242      243       +1     
Impacted Files Coverage Δ
lib/fetch/index.js 80.77% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f7f80...315dbd9. Read the comment docs.

@ronag
Copy link
Member

ronag commented May 3, 2022

CI is still failing?

@ShogunPanda
Copy link
Contributor Author

The falling bench job is the one executing the current master, if I'm not mistaken.

@targos
Copy link
Member

targos commented May 3, 2022

Yes, benchmark current runs with the code of the main branch.

@ronag ronag merged commit c12d109 into nodejs:main May 3, 2022
@ShogunPanda ShogunPanda deleted the update-cronometro-esm branch May 3, 2022 14:04
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants