Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert #1349 #1408

Merged
merged 1 commit into from May 3, 2022
Merged

chore: revert #1349 #1408

merged 1 commit into from May 3, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented May 3, 2022

There was nothing wrong with the original pre-commit hook. The only thing #1349 does is introduce an extra dependency that needs to be downloaded (which could be compromised down the road).

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #1408 (4a2a3e8) into main (c12d109) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files          47       47           
  Lines        4250     4250           
=======================================
  Hits         4007     4007           
  Misses        243      243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12d109...4a2a3e8. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this was very annoying.

LGTM

@mcollina mcollina merged commit 3ec5a8e into nodejs:main May 3, 2022
@Fdawgs Fdawgs deleted the chore/lints branch May 3, 2022 17:57
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants