New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Headers): do not brand-check toString & Symbol.toStringTag #1430
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
- Coverage 94.34% 94.34% -0.01%
==========================================
Files 49 49
Lines 4243 4241 -2
==========================================
- Hits 4003 4001 -2
Misses 240 240
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes 2 bugs:
Headers.toString
should be inherited from Object's prototype.Symbol.toStringTag
getter should not be brand checked.