Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Headers Iterator): make spec compliant #1431

Merged
merged 1 commit into from May 10, 2022

Conversation

KhafraDev
Copy link
Member

Follow-up to #1423 that provides hopefully 100% spec compliance.

See: whatwg/fetch#1437 (comment)

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #1431 (638ef59) into main (b1a6278) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1431   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          49       49           
  Lines        4243     4246    +3     
=======================================
+ Hits         4003     4006    +3     
  Misses        240      240           
Impacted Files Coverage Δ
lib/fetch/headers.js 95.33% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a6278...638ef59. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 32c54ce into nodejs:main May 10, 2022
@KhafraDev KhafraDev deleted the headers-iterator-fixes branch May 10, 2022 21:18
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants