New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): make RequestInit
properties assignable
#1446
Conversation
RequestInit
properties are assignableRequestInit
properties assignable
Codecov Report
@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 49 49
Lines 4231 4231
=======================================
Hits 3993 3993
Misses 238 238 Continue to review full report at Codecov.
|
Can you fix the PR title? the linter is complaining? |
I’m not sure why that is - the error message is complaining about the old title:
I’ll try changing it and back again |
RequestInit
properties assignableRequestInit
props assignable
RequestInit
props assignableRequestInit
properties assignable
All the checks here show as successful (which is where I got confused as well), but the action shows that it's failing:
I re-ran it and now it passed. 🤷 |
RequestInit
properties assignableRequestInit
properties assignable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the prompt reviews and merging! What's the release cadence by the way? Are you looking to merge a few more PRs before publishing a new version? |
Fixes #1445