Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): make RequestInit properties assignable #1446

Merged
merged 1 commit into from May 18, 2022
Merged

fix(types): make RequestInit properties assignable #1446

merged 1 commit into from May 18, 2022

Conversation

NMinhNguyen
Copy link
Contributor

Fixes #1445

@NMinhNguyen NMinhNguyen changed the title Make sure RequestInit properties are assignable fix(RequestInit): make RequestInit properties assignable May 17, 2022
@NMinhNguyen NMinhNguyen changed the title fix(RequestInit): make RequestInit properties assignable fix(RequestInit): make RequestInit properties assignable May 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1446 (36cf3c9) into main (5478cdd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          49       49           
  Lines        4231     4231           
=======================================
  Hits         3993     3993           
  Misses        238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5478cdd...36cf3c9. Read the comment docs.

@mcollina
Copy link
Member

Can you fix the PR title? the linter is complaining?

@NMinhNguyen
Copy link
Contributor Author

I’m not sure why that is - the error message is complaining about the old title:

No release type found in pull request title "Make sure RequestInit properties are assignable".

I’ll try changing it and back again

@NMinhNguyen NMinhNguyen changed the title fix(RequestInit): make RequestInit properties assignable fix(RequestInit): make RequestInit props assignable May 17, 2022
@NMinhNguyen NMinhNguyen changed the title fix(RequestInit): make RequestInit props assignable fix(RequestInit): make RequestInit properties assignable May 17, 2022
@NMinhNguyen
Copy link
Contributor Author

NMinhNguyen commented May 17, 2022

I think all the checks are passing?

image

@KhafraDev
Copy link
Member

KhafraDev commented May 17, 2022

All the checks here show as successful (which is where I got confused as well), but the action shows that it's failing:

Error: No release type found in pull request title "Make sure `RequestInit` properties are assignable". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

I re-ran it and now it passed. 🤷

@NMinhNguyen NMinhNguyen changed the title fix(RequestInit): make RequestInit properties assignable fix(types): make RequestInit properties assignable May 18, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3b5353a into nodejs:main May 18, 2022
@NMinhNguyen NMinhNguyen deleted the assignable-request-init branch May 18, 2022 11:40
@NMinhNguyen
Copy link
Contributor Author

Thanks for the prompt reviews and merging! What's the release cadence by the way? Are you looking to merge a few more PRs before publishing a new version?

KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove readonly from RequestInit typings
4 participants