Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Response.json #1452

Merged
merged 3 commits into from May 19, 2022
Merged

feat: add Response.json #1452

merged 3 commits into from May 19, 2022

Conversation

KhafraDev
Copy link
Member

whatwg/fetch@b3bfd0c

Passes all WPTs. Re-opens #1218 and updates everything to follow changes made.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022

Codecov Report

Merging #1452 (97f2766) into main (3b5353a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1452      +/-   ##
==========================================
+ Coverage   94.37%   94.40%   +0.02%     
==========================================
  Files          49       49              
  Lines        4231     4252      +21     
==========================================
+ Hits         3993     4014      +21     
  Misses        238      238              
Impacted Files Coverage Δ
lib/fetch/response.js 88.95% <100.00%> (+1.11%) ⬆️
lib/fetch/util.js 81.25% <100.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5353a...97f2766. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev
Copy link
Member Author

With Deno, a null init doesn't throw. I'm not sure if this is a bug or intended behavior though. In this implementation, it still throws an error.

@ronag ronag merged commit 0d8877a into nodejs:main May 19, 2022
@KhafraDev KhafraDev deleted the response-json branch May 19, 2022 14:45
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* feat: add `Response.json`

* fix: serialize value properly

* fix: types & more coverage
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* feat: add `Response.json`

* fix: serialize value properly

* fix: types & more coverage
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* feat: add `Response.json`

* fix: serialize value properly

* fix: types & more coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants