New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Response.json
#1452
feat: add Response.json
#1452
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1452 +/- ##
==========================================
+ Coverage 94.37% 94.40% +0.02%
==========================================
Files 49 49
Lines 4231 4252 +21
==========================================
+ Hits 3993 4014 +21
Misses 238 238
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
With Deno, a null init doesn't throw. I'm not sure if this is a bug or intended behavior though. In this implementation, it still throws an error. |
* feat: add `Response.json` * fix: serialize value properly * fix: types & more coverage
* feat: add `Response.json` * fix: serialize value properly * fix: types & more coverage
* feat: add `Response.json` * fix: serialize value properly * fix: types & more coverage
whatwg/fetch@b3bfd0c
Passes all WPTs. Re-opens #1218 and updates everything to follow changes made.