Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace import of URL class with global reference #1455

Merged
merged 1 commit into from May 19, 2022
Merged

refactor: replace import of URL class with global reference #1455

merged 1 commit into from May 19, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented May 19, 2022

closes #1450

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited

Codecov Report

Merging #1455 (30451c7) into main (d13ffb5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1455      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -0.01%     
==========================================
  Files          49       49              
  Lines        4231     4230       -1     
==========================================
- Hits         3993     3992       -1     
  Misses        238      238
Impacted Files Coverage Δ
lib/proxy-agent.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13ffb5...30451c7. Read the comment docs.

mcollina
mcollina approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 324beb6 into nodejs:main May 19, 2022
@Fdawgs Fdawgs deleted the ref/globals branch May 19, 2022 14:59
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
@Fdawgs @KhafraDev
refactor: replace import of URL class with global reference (nodejs…
beeb276 
…#1455)
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@Fdawgs @metcoder95
refactor: replace import of URL class with global reference (nodejs…
76bfcc0 
…#1455)
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@Fdawgs @crysmags
refactor: replace import of URL class with global reference (nodejs…
dfa34e4 
…#1455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit import of URL?
4 participants
@Fdawgs @codecov-commenter @mcollina @ronag