New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add documentation for reply accepting a function as the data parameter #1456
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1456 +/- ##
=======================================
Coverage 94.42% 94.42%
=======================================
Files 49 49
Lines 4271 4271
=======================================
Hits 4033 4033
Misses 238 238 Continue to review full report at Codecov.
|
The failed test
is it a known "flaky" test? it seems something related to the platform more than to the test 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please update the PR title an action fails. |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
@mcollina @Fdawgs It seems that the build on latest windows and node 16 is failing on |
Documentation deployment is failing now: https://github.com/nodejs/undici/runs/6558409571?check_suite_focus=true |
…rameter (nodejs#1456) * Add a small paragraph documenting reply accept a function as the data parameter * Update docs/best-practices/mocking-request.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
…rameter (nodejs#1456) * Add a small paragraph documenting reply accept a function as the data parameter * Update docs/best-practices/mocking-request.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
…rameter (nodejs#1456) * Add a small paragraph documenting reply accept a function as the data parameter * Update docs/best-practices/mocking-request.md Co-authored-by: Frazer Smith <frazer.dev@outlook.com> Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Following up from this discussion #1185 I thought there was a missing bit in the doc around the fact that the
reply
data
parameter can be a function that will have the mocked request options as input .