Passing correct host header to proxy in ProxyAgent #1624
Merged
+18
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protometa
changed the title
|
@protometa could you please resolve conflicts? |
silverwind
approved these changes
Sep 20, 2022
Codecov ReportBase: 94.89% // Head: 94.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1624 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 53 53
Lines 4803 4803
=======================================
Hits 4558 4558
Misses 245 245
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* slight refactor of test * failing test for nodejs#1623 * ProxyAgent passing correct host headers to proxy, fixes nodejs#1623 * add issue # to test * import fetch for proxy text
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* slight refactor of test * failing test for nodejs#1623 * ProxyAgent passing correct host headers to proxy, fixes nodejs#1623 * add issue # to test * import fetch for proxy text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1623