fix(fetch): hangs on a stream response with manual redirect #1627
+31
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 What's in there?
We found out that
fetch()
hangs when consuming the stream body of a redirect, when{ redirect: 'manual' }
is set.Full discussion: #1618
🧪 How to test?
It's covered with unit test:
npm run test:fetch
Without the fix, you'll see a new test failing like this: